chore(dev-docs) Entropy Guide Edits - 1 #3023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
cprussin
approved these changes
Sep 5, 2025
Collaborator
cprussin
left a comment
cprussin
left a comment
There was a problem hiding this comment.
Overall LGTM, most important thing to change before you merge is to make sure you don't have a default case anywhere that you're using the sum types pattern as it breaks exhaustivity checks, and that's one of the main reasons to use that pattern in the first place
| @@ -0,0 +1,125 @@ | |||
| "use client"; | |||
Collaborator
There was a problem hiding this comment.
Not something you need to worry about @aditya520 but just a note to self, we should probably look into using async server components from markdown to see if it's possible cc @alexcambose
apps/developer-hub/src/components/EntropyTable/entropy-api-data-fetcher.tsx
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/EntropyTable/entropy-api-data-fetcher.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?